diff options
| author | Nick White <git@njw.name> | 2020-12-03 15:13:22 +0000 |
|---|---|---|
| committer | Nick White <git@njw.name> | 2020-12-03 15:16:14 +0000 |
| commit | 38dbdd0b21fb363e3f63fd3ea50272975e98eb77 (patch) | |
| tree | 19a3a48f595f62afc69f7a4e8092350a147b3c7b | |
| parent | df364cbf93e4ab5b4db8b924b8396f4fb9caa149 (diff) | |
Don't upload binarised pdf twice needlessly
This can also result in the file being uploaded twice simultaneously,
as up() is running in a separate goroutine. This can cause failures
on Windows as the file is attempted to be removed by one upload
process while being open to upload by the other process. Probably it
could also fail if the process completed by one (so the file was
deleted) before being started by the other.
| -rw-r--r-- | internal/pipeline/pipeline.go | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/internal/pipeline/pipeline.go b/internal/pipeline/pipeline.go index 20400ad..13339d7 100644 --- a/internal/pipeline/pipeline.go +++ b/internal/pipeline/pipeline.go @@ -358,11 +358,6 @@ func Analyse(conn Pipeliner) func(chan string, chan string, chan error, *log.Log return } up <- fn - key := bookname + "/" + bookname + ".binarised.pdf" - conn.Log("Uploading", key) - err := conn.Upload(conn.WIPStorageId(), key, fn) - if err != nil { - } } for _, pg := range colourimgs { |