From 251355f8f6bc397e67ce28b66164759789aa6750 Mon Sep 17 00:00:00 2001 From: Nick White Date: Mon, 13 Feb 2023 11:06:52 +0000 Subject: rescribe: Improve error messages in cases of PDF image extraction failure --- cmd/rescribe/gui.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/rescribe/gui.go b/cmd/rescribe/gui.go index ef58fce..f14f288 100644 --- a/cmd/rescribe/gui.go +++ b/cmd/rescribe/gui.go @@ -498,7 +498,7 @@ func startGui(log *log.Logger, cmd string, gbookcmd string, training string, tes // happens if extractPdfImgs recovers from a PDF panic, // which will occur if we encounter an image we can't decode if bookdir == "" { - msg := fmt.Sprintf("Error opening PDF\nThe format of this PDF is not supported, extract the images to .jpg manually into a folder first.\n") + msg := fmt.Sprintf("Error opening PDF\nThe format of this PDF is not supported, extract the images to .jpg manually into a\nfolder first, using a tool like the PDF image extractor at https://pdfcandy.com/extract-images.html.\n") dialog.ShowError(errors.New(msg), myWindow) fmt.Fprintf(os.Stderr, msg) @@ -528,6 +528,9 @@ func startGui(log *log.Logger, cmd string, gbookcmd string, training string, tes } if err != nil { msg := fmt.Sprintf("Error during processing: %v\n", err) + if strings.HasSuffix(err.Error(), "No images found") && strings.HasSuffix(dir.Text, ".pdf") && !f.IsDir() { + msg = fmt.Sprintf("Error opening PDF\nNo images found in the PDF. Most likely the format of this PDF is not supported,\nextract the images to .jpg manually into a folder first, using a tool like\nthe PDF image extractor at https://pdfcandy.com/extract-images.html.\n") + } dialog.ShowError(errors.New(msg), myWindow) fmt.Fprintf(os.Stderr, msg) -- cgit v1.2.1-24-ge1ad